cmd, core, eth, triedb/pathdb: track node origins in the path database #32418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
force-pushed
the
trie-archive-p1
branch
from
fd1f3a2 to
51844b4
Compare
rjl493456442
commented
Aug 13, 2025
| } | ||
| } | ||
| for _, addr := range deletes { |
There was a problem hiding this comment.
Apply trie insert/update before deletions to avoid loading siblings of deleted nodes within fullNode.
rjl493456442
commented
Aug 13, 2025
| } else { | ||
| err = st.Update(tkey.Bytes(), val) | ||
| err := st.Update(tkey.Bytes(), val) |
There was a problem hiding this comment.
Apply trie insert/update before deletions to avoid loading siblings of deleted nodes within fullNode.
rjl493456442
commented
Aug 21, 2025
| return err | ||
| } | ||
| // Short circuit if the origins are not tracked | ||
| if len(s.nodeOrigin) == 0 { |
There was a problem hiding this comment.
The original values are not encoded into the journal if they are not provided.
rjl493456442
force-pushed
the
trie-archive-p1
branch
from
51844b4 to
cbfa10d
Compare
rjl493456442
force-pushed
the
trie-archive-p1
branch
from
cbfa10d to
ca8006f
Compare
rjl493456442
force-pushed
the
trie-archive-p1
branch
from
ca8006f to
ada22c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step in the trienode history series.
It introduces the
nodeWithOriginstruct in the path database, which tracks the originalvalues of dirty nodes to support trienode history construction.
Note, the original value is always empty in this PR, so it won't break the existing journal
for encoding and decoding. But the compatibility of journal should be handled in the
following PR.